Skip to content

Ipv6 incl hop limit#543

Merged
Thomasdezeeuw merged 6 commits into
rust-lang:masterfrom
andreybuchinskiy:ipv6_incl_header
Dec 5, 2024
Merged

Ipv6 incl hop limit#543
Thomasdezeeuw merged 6 commits into
rust-lang:masterfrom
andreybuchinskiy:ipv6_incl_header

Conversation

@andreybuchinskiy

Copy link
Copy Markdown
Contributor

Adding support for enabling IPV6_RECVHOPLIMIT on sockets for Linux OS

@andreybuchinskiy

Copy link
Copy Markdown
Contributor Author

Clippy is failing, but it is also failing on master. I can make the required changes to make Clippy happy if necessary.

Comment thread src/sys/unix.rs
Comment thread src/socket.rs Outdated
@andreybuchinskiy andreybuchinskiy changed the title Ipv6 incl header Ipv6 incl hop limit Dec 2, 2024

@Thomasdezeeuw Thomasdezeeuw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to ask last time, can you add a test? A basic set & get should be sufficient, see tests/socket.rs.

@Thomasdezeeuw Thomasdezeeuw merged commit 56e625e into rust-lang:master Dec 5, 2024
@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

Thanks @andreybuchinskiy

@andreybuchinskiy andreybuchinskiy deleted the ipv6_incl_header branch December 5, 2024 15:11
@reneleonhardt

reneleonhardt commented Apr 8, 2025

Copy link
Copy Markdown

Hello @Thomasdezeeuw can you add a changelog entry to 0.5.9?

@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

Hello @Thomasdezeeuw can you add a changelog entry to 0.5.9?

This was merged into the 0.6 branch (current master)

@reneleonhardt

Copy link
Copy Markdown

Hello @Thomasdezeeuw can you add a changelog entry to 0.5.9?

This was merged into the 0.6 branch (current master)

GitHub shows that this commit is contained in master:
https://github.com/rust-lang/socket2/commits/v0.5.x/
56e625e

IntelliJ shows that this commit is contained in v0.5.x and master 🙈

When I run cargo package these changes are part of the source artifact... so my best guess still is that they are contained in 0.5.9 😄

Can you update the Branches section in the README to reflect the current release and development branches?

Hasan6979 pushed a commit to NordSecurity/socket2 that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants