Skip to content

Add missing runtime test for _mm_comige_ss and fix _mm_comigt_ss test#2040

Merged
sayantn merged 2 commits intorust-lang:mainfrom
ArunTamil21:add-test-mm-comige-ss
Feb 26, 2026
Merged

Add missing runtime test for _mm_comige_ss and fix _mm_comigt_ss test#2040
sayantn merged 2 commits intorust-lang:mainfrom
ArunTamil21:add-test-mm-comige-ss

Conversation

@ArunTamil21
Copy link
Contributor

@ArunTamil21 ArunTamil21 commented Feb 26, 2026

Add missing test for "_mm_comige_ss" and fix "_mm_comigt_ss"

While looking at issue #798, I noticed two things in the SSE test suite:

  1. "test_mm_comigt_ss" was calling "_mm_comige_ss" instead of "_mm_comigt_ss",
    and had an incorrect expected value — "3.0 > 3.0" was expected to return 1,
    but strictly-greater-than should return 0 for equal values.

  2. "test_mm_comige_ss" was missing entirely.

This PR fixes the bug in the existing test and adds the missing one.

Part of #798.

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2026

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @folkertdev, @sayantn
  • @Amanieu, @folkertdev, @sayantn expanded to Amanieu, folkertdev, sayantn
  • Random selection from Amanieu, folkertdev, sayantn

Copy link
Contributor

@sayantn sayantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove this line from stdarch-verify pls, it bypasses the normal checks for existence of tests.

View changes since this review

@ArunTamil21
Copy link
Contributor Author

Done, removed "_mm_comige_ss" from the skip list in x86-intel.rs.

@sayantn
Copy link
Contributor

sayantn commented Feb 26, 2026

thanks

@sayantn sayantn added this pull request to the merge queue Feb 26, 2026
Merged via the queue into rust-lang:main with commit 6326b77 Feb 26, 2026
77 checks passed
@ArunTamil21 ArunTamil21 deleted the add-test-mm-comige-ss branch February 26, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants