Add missing runtime test for _mm_comige_ss and fix _mm_comigt_ss test#2040
Merged
sayantn merged 2 commits intorust-lang:mainfrom Feb 26, 2026
Merged
Add missing runtime test for _mm_comige_ss and fix _mm_comigt_ss test#2040sayantn merged 2 commits intorust-lang:mainfrom
sayantn merged 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
r? @sayantn rustbot has assigned @sayantn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
sayantn
reviewed
Feb 26, 2026
Contributor
Author
|
Done, removed "_mm_comige_ss" from the skip list in x86-intel.rs. |
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing test for "_mm_comige_ss" and fix "_mm_comigt_ss"
While looking at issue #798, I noticed two things in the SSE test suite:
"test_mm_comigt_ss" was calling "_mm_comige_ss" instead of "_mm_comigt_ss",
and had an incorrect expected value — "3.0 > 3.0" was expected to return 1,
but strictly-greater-than should return 0 for equal values.
"test_mm_comige_ss" was missing entirely.
This PR fixes the bug in the existing test and adds the missing one.
Part of #798.