intrinsic-test: make types generic over SupportedArchitecture#2170
Open
davidtwco wants to merge 3 commits into
Open
intrinsic-test: make types generic over SupportedArchitecture#2170davidtwco wants to merge 3 commits into
SupportedArchitecture#2170davidtwco wants to merge 3 commits into
Conversation
This isn't strictly necessary but these type names were longer than they needed to be.
Refactoring enabling accessing architecture-specific behaviour that isn't associated with either of the return or argument types.
Refactoring enabling accessing architecture-specific behaviour that isn't associated with the specific argument type.
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #2160. This patch contains a refactor which makes the
ArgumentandIntrinsictypes generic over theSupportedArchitectureTesttrait, rather thanIntrinsicTypeDefinition. This makes it easier to add logic that is per-architecture but not necessarily per-type, which is required in the SVE support. It also renames some types to keep them relatively short after these changes.r? @sayantn