Conversation
|
I'm having issues related to Can't test as my dep tree pulls in 0.1 and 0.2 of getrandom, though, so |
josephlr
left a comment
There was a problem hiding this comment.
This looks correct. After reading the documentation for the cargo:rustc-link-lib=[KIND=]NAME instruction in build scripts, the #[link] attribute, and the -l rustc flag, I can confidently say that:
- Adding
"cargo:rustc-link-lib=framework=Security"tobuild.rs - Adding
#[link(name = "Security", kind = "framework")]to anextern "C"block
do the exact same thing, namely passing -l framework=Security to rustc.
Does this mean you would also like to see this change backported to |
|
if 0.1 is getting new releases there's no reason to not also do this in 0.1 |
Closes #204.
iOS code already had link attributes. To be extra safe I would prefer for someone to verify that this change does not break iOS targets.