Avoid unsafe where safety depends on non-local values#1791
Open
dhardy wants to merge 1 commit into
Open
Conversation
Member
|
With any "non-local memory corruption" all bets are off, so I am not sure it's worth to guard against it. Minimizing amount of |
tarcieri
approved these changes
Jun 18, 2026
tarcieri
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure about the memory corruption angle, but avoiding unsafe seems good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Avoid usage of
unsafein contexts where non-local memory corruption (e.g. in RAM) could invalidate a safety contract.Motivation
This could be seen as an alternative fix to #1790, though I'd prefer to merge both PRs.
This PR could have noticeable impacts (performance, code size, panic point). If this is a significant concern we could consider alternatives (not doing this, using a feature flag, adding an explicitly-unsafe variant such as
slice::ChooseUnsafe).