-
Notifications
You must be signed in to change notification settings - Fork 21
Add device specific token to address different IO windows #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anything, this token should naturally be the base address of that window. And yes, that base address would change when reprogramming PCI BARs, but so would the registration against the MMIO or IO bus. A token is well defined for PCI BARs, but it makes the API less simple and obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may use the base address as the token, but we may also have better choices for token.
For example, PCI bar index may be better than base address because we almost need to map the base address to bar index.
So token gives more flexibility to the driver implementation. And it would be easier to support firecracker by simply ignoring the token argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with adding a token with VMM and device specific semantics, is that you have to use your
DeviceIoinstances with a specific device manager, one that can forward a cookie/token that was passed during device registration time. Your device IO trait becomes semantically bound to your device manager, which I feel is not the cleanest approach.Adding a
base: IoAddressargument would already be useful and help devices.