fixed nsmenu activation bug

[adamnemecek]

I'm looking to get feedback on this. I'm not sure if the commented out is necessary, but the menu seems to work fine.

[adamnemecek]

@ArturKovacs @madsmtm @casperstorm do you guys want to verify this? i saw @madsmtm's fix, but it doesn't quite fix it.

[maroider]

So this is meant as an alternative to #1903, right?

[adamnemecek]

#1903 doesn’t work for me. Does it for you?

[maroider]

I don't have a mac, so I can't really test either PR. I've just got this repo set to "watch all activity", like some kind of lunatic.

[ArturKovacs]

Awesome work! Do you mind me pushing to this branch?

[adamnemecek]

I don’t mind but are you sure we don’t care about the code I uncommented? Are you on discord? I’d like to discuss some other nsmenu matters.

[ArturKovacs]

I'm ArturBarnabas#8576 on discord, I wrote to someone, who I believe is you @adamnemecek

[lemarier]

GUYS!!!! IT WORKS 💯

At @tauri-apps we are blocked by this !!!!

Good job!!! ;)

[ArturKovacs]

@adamnemecek please check if my changes look good.

[lemarier]

Well done! Works fine here. Tested with multi-window as well!

[ArturKovacs]

@adamnemecek you seem to be pretty competent at this stuff are you interested in becoming a winit maintainer? @francesca64

[adamnemecek]

Sure. It’s a thankless job but someone has to do it. I’ll look at your changes in a bit.

[ArturKovacs]

Tested with multi-window as well!

Oh no! I just tested that as well and now only the first window shows up. All windows show up on the master branch. Will have to spend some more time with this...

[lemarier]

Tested with multi-window as well!

Oh no! I just tested that as well and now only the first window shows up. All windows show up on the master branch. Will have to spend some more time with this...

Here's the 3 windows are created and show's, I wonder if it's not because they are hidden behind another window?
Running 11.2.3

[madsmtm]

Honestly, at this point I'm beginning to think the examples are the fault; things work as they should if you create the windows after applicationDidFinishLaunching:

Event::NewEvents(event) if event == StartCause::Init => {
    for _ in 0..3 {
        let window = Window::new(&event_loop).unwrap();
        windows.insert(window.id(), window);
    }
}

Maybe it's just not possible to create windows in a clean way, where they show up from the beginning, without resorting to weird hacks?

[madsmtm]

Also, can you please state your MacOS versions? Because there's no difference between #1903 and this on my machine (MacOS 10.14.6 Mojave), but as I said in the linked issue, we would probably have to do something similar to linebender/druid#994 to support higher versions - but it would be nice to know if it is indeed a version-dependent thing!

[adamnemecek]

I’m on Big Sur. This fix is in fact the same thing as what Druid is doing.

[ArturKovacs]

I'm on macOS 10.11. And just to clarify I'm affected by both the menubar not activating and windows not showing up.

I wonder if it's not because they are hidden behind another window?

I start up the example then drag and move the first window away from its initial position and there's no window behind it. Then I close it and a new window suddenly appears at the original spot.

[casperstorm]

I'm on macOS 10.11. And just to clarify I'm affected by both the menubar not activating and windows not showing up.

I wonder if it's not because they are hidden behind another window?

I start up the example then drag and move the first window away from its initial position and there's no window behind it. Then I close it and a new window suddenly appears at the original spot.

Just to tip in: I'm on 10.15 and it is working for me, both single and multiwindow.

[ArturKovacs]

Closing as this was superseded by #1903 and #1922