Skip to content

update advanced options#593

Merged
rustdesk merged 1 commit into
rustdesk:masterfrom
21pages:hide-stop-service
Mar 20, 2026
Merged

update advanced options#593
rustdesk merged 1 commit into
rustdesk:masterfrom
21pages:hide-stop-service

Conversation

@21pages

@21pages 21pages commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

hide-stop-service, keep-awake-during-outgoing-sessions, keep-awake-during-incoming-sessions

Summary by CodeRabbit

  • Documentation
    • Added comprehensive docs for three Android client configuration settings: keep-awake-during-incoming-sessions, keep-awake-during-outgoing-sessions, and hide-stop-service — including options, defaults, and examples in all supported languages.
    • Adjusted some examples/default displays and localized table headers; duplicated hide-stop-service insertion noted and ordering updated among advanced settings.

@coderabbitai

coderabbitai Bot commented Mar 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c60b4044-eced-412e-a68d-7105e5b1fc53

📥 Commits

Reviewing files that changed from the base of the PR and between 22c293c and 243d136.

📒 Files selected for processing (11)
  • content/self-host/client-configuration/advanced-settings/_index.de.md
  • content/self-host/client-configuration/advanced-settings/_index.en.md
  • content/self-host/client-configuration/advanced-settings/_index.es.md
  • content/self-host/client-configuration/advanced-settings/_index.fr.md
  • content/self-host/client-configuration/advanced-settings/_index.it.md
  • content/self-host/client-configuration/advanced-settings/_index.ja.md
  • content/self-host/client-configuration/advanced-settings/_index.pl.md
  • content/self-host/client-configuration/advanced-settings/_index.pt.md
  • content/self-host/client-configuration/advanced-settings/_index.ro.md
  • content/self-host/client-configuration/advanced-settings/_index.zh-cn.md
  • content/self-host/client-configuration/advanced-settings/_index.zh-tw.md
🚧 Files skipped from review as they are similar to previous changes (5)
  • content/self-host/client-configuration/advanced-settings/_index.ro.md
  • content/self-host/client-configuration/advanced-settings/_index.en.md
  • content/self-host/client-configuration/advanced-settings/_index.pt.md
  • content/self-host/client-configuration/advanced-settings/_index.zh-cn.md
  • content/self-host/client-configuration/advanced-settings/_index.it.md

📝 Walkthrough

Walkthrough

Documentation across multiple localized advanced-settings pages was updated to add three new configuration entries: keep-awake-during-incoming-sessions, keep-awake-during-outgoing-sessions (both Y/N, default Y), and hide-stop-service (Y/N, default N). Minor example/table header adjustments and a duplicated insertion of hide-stop-service appear in some locales.

Changes

Cohort / File(s) Summary
Android & Service Settings Documentation
content/self-host/client-configuration/advanced-settings/_index.de.md, content/self-host/client-configuration/advanced-settings/_index.en.md, content/self-host/client-configuration/advanced-settings/_index.es.md, content/self-host/client-configuration/advanced-settings/_index.fr.md, content/self-host/client-configuration/advanced-settings/_index.it.md, content/self-host/client-configuration/advanced-settings/_index.ja.md, content/self-host/client-configuration/advanced-settings/_index.pl.md, content/self-host/client-configuration/advanced-settings/_index.pt.md, content/self-host/client-configuration/advanced-settings/_index.ro.md, content/self-host/client-configuration/advanced-settings/_index.zh-cn.md, content/self-host/client-configuration/advanced-settings/_index.zh-tw.md
Added documentation for keep-awake-during-incoming-sessions and keep-awake-during-outgoing-sessions (Y/N, default Y) and hide-stop-service (Y/N, default N). Applied across all listed locales; some files show reordered sections, localized table header changes, example updates (e.g., enable-directx-capture), and a duplicated hide-stop-service insertion in some diffs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through docs in every tongue,
Two wake-locks set, a third hidden from view,
Tables and examples neatly spun,
A bilingual tumble — updated and new! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'update advanced options' is vague and generic, using non-descriptive terminology that doesn't specify which advanced options are being added or updated. Consider using a more specific title like 'Add hide-stop-service and screen wake-lock settings documentation' to clearly identify the key changes being made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@content/self-host/client-configuration/advanced-settings/_index.fr.md`:
- Around line 1256-1258: Replace the English table header "Values | Default |
Example" with the French localized labels used elsewhere in this file (e.g.,
"Valeurs | Défaut | Exemple") so the table header matches the rest of the French
content; update the header row that currently reads "Values | Default | Example"
to the French equivalents and ensure surrounding formatting remains unchanged.

In `@content/self-host/client-configuration/advanced-settings/_index.it.md`:
- Around line 1256-1258: Replace the English table headers "Values | Default |
Example" with their Italian equivalents in the localized document: change the
header row in the table that currently reads "| Values | Default | Example |" to
"| Valori | Predefinito | Esempio |" so the headers in
advanced-settings/_index.it.md (the table starting with the line containing
those headers and the following alignment row) match the surrounding Italian
localization.

In `@content/self-host/client-configuration/advanced-settings/_index.ja.md`:
- Around line 1267-1269: Replace the English table headers in the JA doc row
that currently reads "| Values | Default | Example |" with Japanese equivalents
to match the rest of the file (for example "値", "デフォルト", "例"); update the
matching separator row and any corresponding header cells so the table header
and subsequent cells (e.g., the row containing "`hide-stop-service=Y`") are
localized consistently; ensure spacing/markdown table syntax remains valid after
the header text change.

In `@content/self-host/client-configuration/advanced-settings/_index.pt.md`:
- Around line 1258-1260: Replace the English table header "Values | Default |
Example" used for the hide-stop-service section with Portuguese headers to match
the rest of the file (e.g., "Valores | Padrão | Exemplo"); update the header row
where the table for hide-stop-service is defined so it reads "| Valores | Padrão
| Exemplo |" while keeping the existing value row ("| Y, N | N |
`hide-stop-service=Y`") unchanged.

In `@content/self-host/client-configuration/advanced-settings/_index.ro.md`:
- Around line 1268-1270: The table headers are in English; replace them with
Romanian equivalents to match localization (e.g., change "Values | Default |
Example" to "Valori | Implicit | Exemplu") in the table near the
`hide-stop-service=Y` example so the headers align with surrounding Romanian
sections; ensure formatting and column alignment (`:------:`) remain unchanged
and update any other nearby tables in this block if they use the same English
header labels.

In `@content/self-host/client-configuration/advanced-settings/_index.zh-cn.md`:
- Around line 1257-1259: The table header for the `hide-stop-service` row uses
English labels ("Values | Default | Example"); update those header cells to
Chinese equivalents to match the rest of the localized file (for example use "取值
| 默认 | 示例" or the project's chosen Chinese translations) so the row with
`hide-stop-service=Y` is consistent with surrounding localization.

In `@content/self-host/client-configuration/advanced-settings/_index.zh-tw.md`:
- Around line 1268-1270: The table header is in English ("Values | Default |
Example") but surrounding content is Traditional Chinese; change the header to
Traditional Chinese (e.g., "可選值 | 預設值 | 範例") so it matches locale, update the
same markdown table row that contains "| Y, N | N | `hide-stop-service=Y` |" and
keep the existing formatting/backticks intact to preserve examples and
alignment.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 842aca1d-ff14-4186-9bf6-2e50d44d6833

📥 Commits

Reviewing files that changed from the base of the PR and between 03fe896 and 22c293c.

📒 Files selected for processing (11)
  • content/self-host/client-configuration/advanced-settings/_index.de.md
  • content/self-host/client-configuration/advanced-settings/_index.en.md
  • content/self-host/client-configuration/advanced-settings/_index.es.md
  • content/self-host/client-configuration/advanced-settings/_index.fr.md
  • content/self-host/client-configuration/advanced-settings/_index.it.md
  • content/self-host/client-configuration/advanced-settings/_index.ja.md
  • content/self-host/client-configuration/advanced-settings/_index.pl.md
  • content/self-host/client-configuration/advanced-settings/_index.pt.md
  • content/self-host/client-configuration/advanced-settings/_index.ro.md
  • content/self-host/client-configuration/advanced-settings/_index.zh-cn.md
  • content/self-host/client-configuration/advanced-settings/_index.zh-tw.md

Comment thread content/self-host/client-configuration/advanced-settings/_index.fr.md Outdated
Comment thread content/self-host/client-configuration/advanced-settings/_index.it.md Outdated
Comment thread content/self-host/client-configuration/advanced-settings/_index.ja.md Outdated
Comment thread content/self-host/client-configuration/advanced-settings/_index.pt.md Outdated
Comment thread content/self-host/client-configuration/advanced-settings/_index.zh-cn.md Outdated
Comment thread content/self-host/client-configuration/advanced-settings/_index.zh-tw.md Outdated
Signed-off-by: 21pages <sunboeasy@gmail.com>
@21pages
21pages force-pushed the hide-stop-service branch from 22c293c to 243d136 Compare March 17, 2026 11:19
@rustdesk
rustdesk merged commit b665592 into rustdesk:master Mar 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants