update advanced options#593
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughDocumentation across multiple localized advanced-settings pages was updated to add three new configuration entries: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@content/self-host/client-configuration/advanced-settings/_index.fr.md`:
- Around line 1256-1258: Replace the English table header "Values | Default |
Example" with the French localized labels used elsewhere in this file (e.g.,
"Valeurs | Défaut | Exemple") so the table header matches the rest of the French
content; update the header row that currently reads "Values | Default | Example"
to the French equivalents and ensure surrounding formatting remains unchanged.
In `@content/self-host/client-configuration/advanced-settings/_index.it.md`:
- Around line 1256-1258: Replace the English table headers "Values | Default |
Example" with their Italian equivalents in the localized document: change the
header row in the table that currently reads "| Values | Default | Example |" to
"| Valori | Predefinito | Esempio |" so the headers in
advanced-settings/_index.it.md (the table starting with the line containing
those headers and the following alignment row) match the surrounding Italian
localization.
In `@content/self-host/client-configuration/advanced-settings/_index.ja.md`:
- Around line 1267-1269: Replace the English table headers in the JA doc row
that currently reads "| Values | Default | Example |" with Japanese equivalents
to match the rest of the file (for example "値", "デフォルト", "例"); update the
matching separator row and any corresponding header cells so the table header
and subsequent cells (e.g., the row containing "`hide-stop-service=Y`") are
localized consistently; ensure spacing/markdown table syntax remains valid after
the header text change.
In `@content/self-host/client-configuration/advanced-settings/_index.pt.md`:
- Around line 1258-1260: Replace the English table header "Values | Default |
Example" used for the hide-stop-service section with Portuguese headers to match
the rest of the file (e.g., "Valores | Padrão | Exemplo"); update the header row
where the table for hide-stop-service is defined so it reads "| Valores | Padrão
| Exemplo |" while keeping the existing value row ("| Y, N | N |
`hide-stop-service=Y`") unchanged.
In `@content/self-host/client-configuration/advanced-settings/_index.ro.md`:
- Around line 1268-1270: The table headers are in English; replace them with
Romanian equivalents to match localization (e.g., change "Values | Default |
Example" to "Valori | Implicit | Exemplu") in the table near the
`hide-stop-service=Y` example so the headers align with surrounding Romanian
sections; ensure formatting and column alignment (`:------:`) remain unchanged
and update any other nearby tables in this block if they use the same English
header labels.
In `@content/self-host/client-configuration/advanced-settings/_index.zh-cn.md`:
- Around line 1257-1259: The table header for the `hide-stop-service` row uses
English labels ("Values | Default | Example"); update those header cells to
Chinese equivalents to match the rest of the localized file (for example use "取值
| 默认 | 示例" or the project's chosen Chinese translations) so the row with
`hide-stop-service=Y` is consistent with surrounding localization.
In `@content/self-host/client-configuration/advanced-settings/_index.zh-tw.md`:
- Around line 1268-1270: The table header is in English ("Values | Default |
Example") but surrounding content is Traditional Chinese; change the header to
Traditional Chinese (e.g., "可選值 | 預設值 | 範例") so it matches locale, update the
same markdown table row that contains "| Y, N | N | `hide-stop-service=Y` |" and
keep the existing formatting/backticks intact to preserve examples and
alignment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 842aca1d-ff14-4186-9bf6-2e50d44d6833
📒 Files selected for processing (11)
content/self-host/client-configuration/advanced-settings/_index.de.mdcontent/self-host/client-configuration/advanced-settings/_index.en.mdcontent/self-host/client-configuration/advanced-settings/_index.es.mdcontent/self-host/client-configuration/advanced-settings/_index.fr.mdcontent/self-host/client-configuration/advanced-settings/_index.it.mdcontent/self-host/client-configuration/advanced-settings/_index.ja.mdcontent/self-host/client-configuration/advanced-settings/_index.pl.mdcontent/self-host/client-configuration/advanced-settings/_index.pt.mdcontent/self-host/client-configuration/advanced-settings/_index.ro.mdcontent/self-host/client-configuration/advanced-settings/_index.zh-cn.mdcontent/self-host/client-configuration/advanced-settings/_index.zh-tw.md
Signed-off-by: 21pages <sunboeasy@gmail.com>
22c293c to
243d136
Compare
hide-stop-service, keep-awake-during-outgoing-sessions, keep-awake-during-incoming-sessions
Summary by CodeRabbit