Skip to content

fix(faq): update stale #install anchor across all locales#621

Merged
rustdesk merged 2 commits into
rustdesk:masterfrom
OneVth:fix/faq-install-anchor
Jul 7, 2026
Merged

fix(faq): update stale #install anchor across all locales#621
rustdesk merged 2 commits into
rustdesk:masterfrom
OneVth:fix/faq-install-anchor

Conversation

@OneVth

@OneVth OneVth commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

While translating the docs into Korean, I noticed the #install anchor on line 28 of the Server Pro FAQ no longer resolves.

The install-script section had an ### Install heading (3bc06d1), which was later renamed to ## Method 2: install.sh (063de19). The FAQ still points at the old #install anchor, so it now resolves to nothing.

This updates line 28 to the correct anchor across all 12 locales, using each locale's actual slug and localizing the path.

Split into two commits: the English source fix, then the translations.

Summary by CodeRabbit

  • Documentation
    • Updated the “Simple Install Script” FAQ across multiple languages with corrected links to the relevant installation instructions.
    • Users are now taken directly to the appropriate “Method 2” section in each localized guide, improving navigation and reducing confusion.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Step 4 of the "Simple Install Script" FAQ entry was updated across 12 localized FAQ files (de, en, es, fr, it, ja, ko, pl, pt, ro, zh-cn, zh-tw) to point the documentation link to the locale-specific "method-2-installsh" anchor instead of the previous generic or English #install anchor.

Changes

Localized FAQ link updates

Layer / File(s) Summary
Update install script link anchors
content/self-host/rustdesk-server-pro/faq/_index.{de,en,es,fr,it,ja,ko,pl,pt,ro,zh-cn,zh-tw}.md
Step 4's link in each localized FAQ file was updated to reference the locale-specific "method-2-installsh" anchor on the install script documentation page instead of the previous #install anchor or generic page reference.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing the outdated #install FAQ anchor across locales.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@content/self-host/rustdesk-server-pro/faq/_index.ko.md`:
- Line 28: The Korean FAQ link text is still in English, so update the visible
anchor text in the markdown entry to a localized Korean phrase while keeping the
current destination URL unchanged. Make this adjustment in the FAQ content where
the translated step references the install script page so the surrounding Korean
copy stays consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 753469f0-d07a-4225-86de-7e97768168cb

📥 Commits

Reviewing files that changed from the base of the PR and between 2470a16 and a4a9163.

📒 Files selected for processing (12)
  • content/self-host/rustdesk-server-pro/faq/_index.de.md
  • content/self-host/rustdesk-server-pro/faq/_index.en.md
  • content/self-host/rustdesk-server-pro/faq/_index.es.md
  • content/self-host/rustdesk-server-pro/faq/_index.fr.md
  • content/self-host/rustdesk-server-pro/faq/_index.it.md
  • content/self-host/rustdesk-server-pro/faq/_index.ja.md
  • content/self-host/rustdesk-server-pro/faq/_index.ko.md
  • content/self-host/rustdesk-server-pro/faq/_index.pl.md
  • content/self-host/rustdesk-server-pro/faq/_index.pt.md
  • content/self-host/rustdesk-server-pro/faq/_index.ro.md
  • content/self-host/rustdesk-server-pro/faq/_index.zh-cn.md
  • content/self-host/rustdesk-server-pro/faq/_index.zh-tw.md

2. VPS, 베어 메탈 또는 Linux VM을 생성하세요.
3. DNS와 SSL을 사용하려면 DNS 이름, 예를 들어 `rustdesk.yourdomain.com`를 생성하세요.
4. [This page](https://rustdesk.com/docs/en/self-host/rustdesk-server-pro/installscript/#install)를 실행하세요.
4. [This page](https://rustdesk.com/docs/ko/self-host/rustdesk-server-pro/installscript/#방법-2-installsh)를 실행하세요.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Keep the Korean link text localized.

The new destination is fine, but This page is still English in the Korean FAQ. Please localize the visible link text so the translated step reads consistently.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@content/self-host/rustdesk-server-pro/faq/_index.ko.md` at line 28, The
Korean FAQ link text is still in English, so update the visible anchor text in
the markdown entry to a localized Korean phrase while keeping the current
destination URL unchanged. Make this adjustment in the FAQ content where the
translated step references the install script page so the surrounding Korean
copy stays consistent.

@rustdesk
rustdesk merged commit 06b38eb into rustdesk:master Jul 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants