test(event): cover notification rule replacement#73
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds focused regression coverage for the bucket notification update path in
event add.The recent event shorthand normalization fix ensures shorthand values like
putare converted before notification rules are persisted. Existing unit coverage verified the normalization helper itself, but it did not verify the replace-by-ARN behavior thatevent adduses when updating an existing notification target. That left a gap where normalization could pass in isolation while replacement logic still regressed in the path that actually writes the updated rule.This patch adds a unit test that starts with an existing notification rule, parses a mixed shorthand and canonical event list, and then upserts a rule with the same ARN. The test asserts that the old rule is replaced rather than duplicated and that the persisted event list is normalized and deduplicated to a single canonical value.
User Impact
Without this coverage, a future change could reintroduce duplicated rules or persist stale event values when users update an existing notification target with shorthand events.
Validation
I ran the required repository checks:
cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspace