Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a focused regression test for the
event addparsing path when users provide blank--eventvalues such as empty strings or comma-only input.Problem
The recent event-name normalization work updated
parse_event_list, but the fallback branch where filtering removes every provided token was still untested. That left a small gap around a real CLI input shape: users can still pass syntactically present but semantically blank event values.Root Cause
parse_event_listtrims and filters each requested event before deciding whether to apply the defaults3:ObjectCreated:*event. The no-input case already had coverage, but the distinct path where inputs are present and collapse to an empty list after trimming did not.Fix
Add
test_parse_event_list_defaults_when_inputs_are_blankincrates/cli/src/commands/event.rs. The test asserts that blank and comma-only values still trigger the same default event fallback as an entirely empty event list.Validation
cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspace