Skip to content

Upgrade to Hyper 0.10#1

Merged
ctz merged 1 commit into
rustls:masterfrom
bruceadams:master
Jan 14, 2017
Merged

Upgrade to Hyper 0.10#1
ctz merged 1 commit into
rustls:masterfrom
bruceadams:master

Conversation

@bruceadams
Copy link
Copy Markdown

This appears to be required for me to be able to use Hyper 0.10.0.
There is so much here that I do not understand.
I do not know if making this change is appropriate in your library.

@hannobraun
Copy link
Copy Markdown

I don't know enough about this library to speak with any authority, but I believe there's one mistake in this pull request.

Updating a dependency to a new incompatible version (as you are doing here) can break a library user's build, and must therefore be considered a breaking change. This means the version bump to 0.2.2 is not sufficient. The new version should be 0.3.0.

@bruceadams
Copy link
Copy Markdown
Author

Ah, yes! You are certainly correct. I've amended my commit. Thanks @hannobraun for catching my versioning mistake and pointing it out!

@ctz ctz merged commit 1dd417e into rustls:master Jan 14, 2017
@ctz
Copy link
Copy Markdown
Member

ctz commented Jan 14, 2017

Thanks! v0.3.0 should appear on crates.io any time now.

ctz pushed a commit that referenced this pull request Sep 5, 2019
Update HttpsConnector for upstream hyper changes
blaggacao pushed a commit to blaggacao/hyper-rustls that referenced this pull request Oct 13, 2020
Modifies util::load_private_key to support PKCS8, adds tests
erickt pushed a commit to erickt/hyper-rustls that referenced this pull request Feb 15, 2026
Clarify and expand documentation.
erickt pushed a commit to erickt/hyper-rustls that referenced this pull request Feb 15, 2026
* Rename more tests

* Clean up smoke test

* fmt

* Clean up ci and remove all-features test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants