ThingFilterContext and ISyncSimple#10
Merged
Zetrith merged 1 commit intorwmt:developmentfrom Jul 6, 2023
Merged
Conversation
SokyranTheDragon
pushed a commit
to SokyranTheDragon/MultiplayerAPI
that referenced
this pull request
Jun 19, 2023
The usage of Harmony was a big oversight on my part which has now been corrected. The removal of ThingFilterContext and ISyncSimple happened due to rwmt#10
Member
|
Looks like there's a conflict preventing the merge. I would have fixed those conflicts myself, however I can't seem to find a way to do it without discarding this PR and commit and then making my own. I'm pretty sure this will also conflict with #9, however I believe that this one is of higher importance right now (as the one I've made still needs some changes to the rwmt/Multiplayer#381 to be ready) so I'll just handle that on my end once that happens. |
Member
|
Apparently it's a whitespace mismatch, Zetrith was going to update it |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the API code from rwmt/Multiplayer#387