test-pyproject-toml#47
Closed
hadijannat wants to merge 15 commits into
Closed
Conversation
hadijannat
force-pushed
the
test-pyproject-toml
branch
from
d03eaff to
72d9ff9
Compare
s-heppner
requested changes
Jul 5, 2024
Member
|
And then furthermore, this PR should probably point at eclipse-basyx/basyx-python-sdk/main, rather than our fork's main |
Author
|
I think I don't have the permission to push on the main repo, so I created a Fork :) |
- Remove reference to aas-compliance-check from pyproject.toml - Add newline at end of pyproject.toml - Remove entry point for aas-compliance-check from setup.py
s-heppner
requested changes
Jul 5, 2024
| [project] | ||
| name = "basyx-python-sdk" | ||
| version = "0.1.0" # Replace with your actual version | ||
| version = "1.0.0" # actual version |
Member
There was a problem hiding this comment.
The comment is not a particularly good one, as it is obvious that version equals the version
| description = "The Eclipse BaSyx Python SDK, an implementation of the Asset Administration Shell for Industry 4.0 systems" | ||
| authors = [ | ||
| {name = "The Eclipse BaSyx Authors", email = "example@example.com"} # Replace with a real email | ||
| {name = "The Eclipse BaSyx Authors", email = "h.jannatabadi@iat.rwth-aachen.de"} # actual authors |
Member
There was a problem hiding this comment.
If you cannot leave out the E-Mail field, I'd use admins@iat.rwth-aachen.de.
Same thing as above about the comment.
Comment on lines
-6
to
-11
| urllib3>=1.26,<2.0 | ||
| lxml-stubs~=0.5.1 | ||
|
|
||
| jsonschema~=4.7 | ||
| types-python-dateutil | ||
| lxml-stubs~=0.5.1 |
Member
There was a problem hiding this comment.
I'm still not sure about the dependencies, but ignore, if you're not done with them.
| ] | ||
| }, | ||
|
|
||
| ) No newline at end of file |
Member
There was a problem hiding this comment.
No new line at the end of the file
- Add types-python-dateutil to dev dependencies - Update Duration type handling in datatypes.py - Add sphinx-argparse to docs dependencies - Update CI configuration for MyPy and Sphinx
hadijannat
force-pushed
the
test-pyproject-toml
branch
from
22fdeb4 to
b61e183
Compare
Author
|
For further development, see: #51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.