Skip to content

exclude react-globalize files from webpack transforms#11

Merged
alunny merged 1 commit into
rxaviers:masterfrom
alunny:alunny/exclude-in-globalize-webpack-plugin
Jan 13, 2016
Merged

exclude react-globalize files from webpack transforms#11
alunny merged 1 commit into
rxaviers:masterfrom
alunny:alunny/exclude-in-globalize-webpack-plugin

Conversation

@alunny

@alunny alunny commented Nov 13, 2015

Copy link
Copy Markdown
Collaborator

Depends on rxaviers/globalize-webpack-plugin#9 being merged and published as 0.3.0 :)

@alunny alunny force-pushed the alunny/exclude-in-globalize-webpack-plugin branch from 34b3475 to 269dd4b Compare November 13, 2015 06:18
Comment thread util.js Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment needs update for "..contain "react-globalize".

@alunny

alunny commented Jan 13, 2016

Copy link
Copy Markdown
Collaborator Author

@rxaviers now that the globalize-webpack-plugin change is in, I'm going to merge this and publish a new release.

Since it changes the behavior of the module, I'll give it a minor version bump to 0.4.0.

@alunny alunny force-pushed the alunny/exclude-in-globalize-webpack-plugin branch from 2e6d151 to 46bba49 Compare January 13, 2016 19:40
@alunny alunny merged commit 46bba49 into rxaviers:master Jan 13, 2016
@rxaviers

Copy link
Copy Markdown
Owner

👍

+55 (16) 98138-1583, skype: rxaviers
http://rafael.xavier.blog.br

@rxaviers

Copy link
Copy Markdown
Owner

@alunny, this change broke some of my applications (that used react-globalize solely). Please, could you refresh my memory, was it motivated by rxaviers/globalize-webpack-plugin#8? If so, it seems like the correct approach is going to be handling default messages in Globalize, not by this change. What do you think? Thanks.

PS: For clarity, the change in globalize-webpack-plugin is totally fine. I think the problem is to use the filter to skip react-globalize files.

@alunny

alunny commented Jan 19, 2016

Copy link
Copy Markdown
Collaborator Author

Do you have react-globalize in your vendor bundle (in the webpack config), or globalize in the vendor bundle and react-globalize in the app bundle?

I think the filter needs to be there if react-globalize is in the vendor bundle, but causes problems if it's in the app bundle.

@rxaviers

Copy link
Copy Markdown
Owner

I've created a simple example (which probably needs simplifications and improvements) here #12, which shows your update didn't cause any problems. So, please ignore my comment.

PS: I have both globalize and react-globalize in vendors in my app, but I still don't know what's causing the failure. Investigating.

@alunny

alunny commented Jan 19, 2016

Copy link
Copy Markdown
Collaborator Author

Thanks @rxaviers - I'll have a look at #12 and let you know of any suggestions.

@rxaviers

Copy link
Copy Markdown
Owner

Thank you.

@rxaviers

Copy link
Copy Markdown
Owner

@alunny, FYI I'm finally back to this and so far I've noticed #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants