exclude react-globalize files from webpack transforms#11
Conversation
34b3475 to
269dd4b
Compare
There was a problem hiding this comment.
Comment needs update for "..contain "react-globalize".
|
@rxaviers now that the globalize-webpack-plugin change is in, I'm going to merge this and publish a new release. Since it changes the behavior of the module, I'll give it a minor version bump to 0.4.0. |
2e6d151 to
46bba49
Compare
|
👍 +55 (16) 98138-1583, skype: rxaviers |
|
@alunny, this change broke some of my applications (that used react-globalize solely). Please, could you refresh my memory, was it motivated by rxaviers/globalize-webpack-plugin#8? If so, it seems like the correct approach is going to be handling default messages in Globalize, not by this change. What do you think? Thanks. PS: For clarity, the change in globalize-webpack-plugin is totally fine. I think the problem is to use the filter to skip react-globalize files. |
|
Do you have react-globalize in your vendor bundle (in the webpack config), or globalize in the vendor bundle and react-globalize in the app bundle? I think the filter needs to be there if react-globalize is in the vendor bundle, but causes problems if it's in the app bundle. |
|
I've created a simple example (which probably needs simplifications and improvements) here #12, which shows your update didn't cause any problems. So, please ignore my comment. PS: I have both globalize and react-globalize in vendors in my app, but I still don't know what's causing the failure. Investigating. |
|
Thank you. |
Depends on rxaviers/globalize-webpack-plugin#9 being merged and published as 0.3.0 :)