Test fixing CI build - #4
Closed
ryanio wants to merge 1 commit into
Closed
Conversation
ryanio
force-pushed
the
fix-CI-build
branch
2 times, most recently
from
April 17, 2020 20:38
d131270 to
49bf72f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes intermittent CI build failures due to
dtslinterroring out on installing3.9.As a workaround we install the latest
TypeScriptinto each package and usedtslint's--localTsoption. It's not ideal since we only test the types against one version, but it was the existing behavior prior to web3#3464.