Skip to content

The cursor wasn't working to get user tweets and searches. It was always returning the same results#332

Closed
s0ckz wants to merge 2 commits intoryanmcgrath:masterfrom
s0ckz:master
Closed

The cursor wasn't working to get user tweets and searches. It was always returning the same results#332
s0ckz wants to merge 2 commits intoryanmcgrath:masterfrom
s0ckz:master

Conversation

@s0ckz
Copy link
Copy Markdown

@s0ckz s0ckz commented Jun 2, 2014

I also added a sleep property to avoid problems with Twitter rates.

s0ckz added 2 commits June 2, 2014 13:02
It’s now working properly for search and get_user_timeline. I didn’t
test other functions though.
@michaelhelmick
Copy link
Copy Markdown
Collaborator

I'm fine with the fixing the loop, but I think adding a time.sleep in code (that is used in production code for people who use this library) isn't the best solution. Rate-limiting should be handled by the application, and not by Twython. We raise an Exception and the developer can handle the rate limiting on their own (pausing a celery task, etc.) instead of forcing a time.sleep

@s0ckz
Copy link
Copy Markdown
Author

s0ckz commented Jun 3, 2014

I totally agree! The sleep part is more for my app purposes.
Em 03/06/2014 12:49, "Mike Helmick" notifications@github.com escreveu:

I'm fine with the fixing the loop, but I think adding a time.sleep in
code (that is used in production code for people who use this library)
isn't the best solution. Rate-limiting should be handled by the
application, and not by Twython. We raise an Exception and the developer
can handle the rate limiting on their own (pausing a celery task, etc.)
instead of forcing a time.sleep


Reply to this email directly or view it on GitHub
#332 (comment).

@chasrmartin
Copy link
Copy Markdown

Hey, guys, I'm running into this too. Any idea when it'll be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants