Skip to content

Add light specs for yeelight #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rytilahti merged 11 commits into from
Oct 22, 2021
Merged

Add light specs for yeelight #1163

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8386280
Add base specs.yaml for yeelight
Kirmas Oct 20, 2021
2d0e267
Add test for get_model_info
Kirmas Oct 20, 2021
1900aac
fix typo
Kirmas Oct 20, 2021
4419a61
Remove class from test
Kirmas Oct 20, 2021
ea867a0
YeelightModelInfo.__init__ refactoring
Kirmas Oct 20, 2021
7010612
Add GENERIC_MODEL_SPEC_DICT
Kirmas Oct 20, 2021
4fb6baf
YeelightColorTempRange(NamedTuple) was added
Kirmas Oct 20, 2021
19e4be3
Add @dataclass atribute
Kirmas Oct 20, 2021
e80ee23
refactoring
Kirmas Oct 21, 2021
83172cc
Remove dictionary and Add exception
Kirmas Oct 22, 2021
d322884
Revert Exception
Kirmas Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
YeelightModelInfo.__init__ refactoring
  • Loading branch information
@Kirmas
Kirmas committed Oct 20, 2021
commit ea867a00943ccac30010f138ba491880aedbc53c
16 changes: 6 additions & 10 deletions miio/integrations/yeelight/spec_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,10 @@ class YeelightModelInfo:
def __init__(self, model, spec=None):
self.model = model
if spec:
if "color_temp" in spec:
self.color_temp = tuple(spec["color_temp"])
if "night_light" in spec:
self.has_night_light = spec["night_light"]
if "background_light" in spec:
self.has_background_light = spec["background_light"]
if "supports_color" in spec:
self.supports_color = spec["supports_color"]
self.color_temp = tuple(spec.get("color_temp", (1700, 6500)))
self.has_night_light = spec.get("night_light", False)
self.has_background_light = spec.get("background_light", False)
self.supports_color = spec.get("supports_color", False)


class YeelightSpecHelper:
Expand All @@ -41,8 +37,8 @@ def supported_models():
def get_model_info(model) -> YeelightModelInfo:
if model not in YeelightSpecHelper.specs():
_LOGGER.warning(
"Unknown model %s, please open an issue and supply features for this light. Returning generic information."
% model
"Unknown model %s, please open an issue and supply features for this light. Returning generic information.",
model,
)
return YeelightModelInfo(model="generic")
return YeelightModelInfo(model, YeelightSpecHelper.specs().get(model))