Add Roborock S6 Pure to support vacuum models.#1172
Closed
OGKevin wants to merge 1 commit intorytilahti:masterfrom
Closed
Add Roborock S6 Pure to support vacuum models.#1172OGKevin wants to merge 1 commit intorytilahti:masterfrom
OGKevin wants to merge 1 commit intorytilahti:masterfrom
Conversation
home-assistant/core#58550 (comment) Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1172 +/- ##
=======================================
Coverage 77.91% 77.91%
=======================================
Files 79 79
Lines 9220 9221 +1
Branches 761 761
=======================================
+ Hits 7184 7185 +1
Misses 1852 1852
Partials 184 184
Continue to review full report at Codecov.
|
22 tasks
Owner
|
All the model additions should be wait a bit until we have feature flags to signal which non-common features are supported by the given model. Also, could you merge the recent PRs into a single one @OGKevin, and give me a week to come up with a plan for the feature flags prior doing that? |
Contributor
Author
|
Closing in favour of #1173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
home-assistant/core#58550 (comment)