vacuum: return none on is_water_box_attached if unsupported#1178
Merged
vacuum: return none on is_water_box_attached if unsupported#1178
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1178 +/- ##
==========================================
- Coverage 78.30% 78.28% -0.02%
==========================================
Files 84 84
Lines 9518 9520 +2
Branches 775 776 +1
==========================================
Hits 7453 7453
- Misses 1879 1880 +1
- Partials 186 187 +1
Continue to review full report at Codecov.
|
rytilahti
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1168