Add support for viomi.waterheater.e1 devices

[Zuz666]

Just added basic support for 'Viomi Electric Water Heater' devices (viomi.waterheater.e1*): power on/off + status (retrieve properties). Fully tested on real device, works fine.

[rytilahti]

Thanks for the PR! A brief initial review: please add an example response, follow the python naming conventions (foo_bar instead of camelcased fooBar). The property names should be descriptive instead of using the naming used by the protocol itself.

[Zuz666]

@rytilahti Thanks for great code review! I will make the code better as you request.

[makp0]

@Zuz666 , any progress on this pr? 🙂

[Zuz666]

@Zuz666 , any progress on this pr? 🙂

@rytilahti, yep, just check the latest commits!
Fully tested on real device, works fine.

[rytilahti]

Thanks for the update! I added a couple of more comments. Could you also do the following:

• Add an entry to README.md
• Move the code to be under miio/integrations/heater/viomiwaterheater/ - there are other heaters so we may have a common API among all of them at some point :-)

[Zuz666]

• Add an entry to README.md
• Move the code to be under miio/integrations/heater/viomiwaterheater/ - there are other heaters so we may have a common API among all of them at some point :-)

@rytilahti Job done! Please perform a code review.

[rytilahti]

Looking good, I added a couple of very minor changes.

Could you also please add at least tests to the container functionality (see #1174 (review))?

[Zuz666]

Looking good, I added a couple of very minor changes.

Could you also please add at least tests to the container functionality (see #1174 (review))?

Some code for testing done but how can I run this test? Newbie to python. )))

[rytilahti]

Simply execute pytest and it should pick it automatically (as long as the filename and the test functions follow the test_* pattern) :-) btw, did you forget to add the test file to the PR?

You can also run the linting tests locally (tox -e lint or pre-commit run -a) or the whole test suite (simply tox) if you wish.