Skip to content

Allow psr/log ^1.0 || ^2.0 || ^3.0#1373

Merged
phil-davis merged 1 commit intosabre-io:masterfrom
fezfez:patch-1
Dec 9, 2021
Merged

Allow psr/log ^1.0 || ^2.0 || ^3.0#1373
phil-davis merged 1 commit intosabre-io:masterfrom
fezfez:patch-1

Conversation

@fezfez
Copy link
Contributor

@fezfez fezfez commented Dec 8, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1373 (2f0160c) into master (5f273e4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1373   +/-   ##
=========================================
  Coverage     97.37%   97.37%           
  Complexity     2817     2817           
=========================================
  Files           174      174           
  Lines          7996     7996           
=========================================
  Hits           7786     7786           
  Misses          210      210           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f273e4...2f0160c. Read the comment docs.

@phil-davis
Copy link
Contributor

@fezfez this is probably "a good thing" - composer can decide which major version of psr/log it should use.
Please write a few words in the PR describing how this is "a good thing" (for example, maybe it helps when using sabre/dav along with some mix of other dependencies?) Then it will be easy for future readers to see why the change was made.

@fezfez
Copy link
Contributor Author

fezfez commented Dec 9, 2021

If you have locked psr/log:^2.0, the sabre/dev:^3.0 will be installed, witch is not working (in my case) in php ^8.0

@phil-davis phil-davis merged commit fd9a141 into sabre-io:master Dec 9, 2021
@phil-davis
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants