Skip to content

[dev] [No PBI] Select onInputChange Prop#490

Merged
groberts314 merged 3 commits into
devfrom
features/select--on_input_change_prop
Apr 1, 2024
Merged

[dev] [No PBI] Select onInputChange Prop#490
groberts314 merged 3 commits into
devfrom
features/select--on_input_change_prop

Conversation

@razmik-medoxi
Copy link
Copy Markdown
Contributor

No description provided.

@groberts314
Copy link
Copy Markdown
Contributor

@razmik-medoxi What functionality does this enable?

@groberts314 groberts314 added this to the vNextPatch (10.9.7) milestone Apr 1, 2024
@groberts314 groberts314 self-assigned this Apr 1, 2024
Comment thread src/inputs/select/select.jsx Outdated
@razmik-medoxi
Copy link
Copy Markdown
Contributor Author

@razmik-medoxi What functionality does this enable?

@groberts314 I'm exposing react-select's onInputChange prop, I need to get select's input value to trigger an API request and get the events list

@groberts314
Copy link
Copy Markdown
Contributor

I'm exposing react-select's onInputChange prop, I need to get select's input value to trigger an API request and get the events list

How is that different than the ordinary onChange event?

@groberts314 groberts314 added enhancement priority: medium Regular priority for code review risk: low Low Risk/Criticality labels Apr 1, 2024
@razmik-medoxi
Copy link
Copy Markdown
Contributor Author

I'm exposing react-select's onInputChange prop, I need to get select's input value to trigger an API request and get the events list

How is that different than the ordinary onChange event?

onChange is for selectedOption changes, this one is for the input changes

@groberts314
Copy link
Copy Markdown
Contributor

onChange is for selectedOption changes, this one is for the input changes

So, this event fires if someone types in the input versus picking something from the dropdown menu?

@razmik-medoxi
Copy link
Copy Markdown
Contributor Author

onChange is for selectedOption changes, this one is for the input changes

So, this event fires if someone types in the input versus picking something from the dropdown menu?

exactly

@groberts314 groberts314 merged commit d191a9d into dev Apr 1, 2024
@groberts314 groberts314 deleted the features/select--on_input_change_prop branch April 1, 2024 15:30
@groberts314
Copy link
Copy Markdown
Contributor

@razmik-medoxi These changes are available in @saddlebackchurch/react-cm-ui version 10.9.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement priority: medium Regular priority for code review risk: low Low Risk/Criticality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants