[dev] PBI AB#107487 [Data Capture] Ability to set Settings & Preferences of Connection Forms#491
Merged
Merged
Conversation
groberts314
approved these changes
Apr 8, 2024
Comment on lines
+7
to
+12
| 'alternate' | 'bright' | 'condition' | | ||
| 'configuration' | 'disable' | 'highlight' | | ||
| 'inverse' | 'inverse-alternate' | 'light' | | ||
| 'nest' | 'outline' | 'primary' | | ||
| 'secondary' | 'static' | 'subject' | | ||
| 'success' | 'transparent' | 'warning', | ||
| 'alternate' | 'bright' | 'condition' | | ||
| 'configuration' | 'disable' | 'highlight' | | ||
| 'inverse' | 'inverse-alternate' | 'light' | | ||
| 'nest' | 'outline' | 'primary' | | ||
| 'secondary' | 'static' | 'subject' | | ||
| 'success' | 'transparent' | 'warning', |
Contributor
There was a problem hiding this comment.
Was ESLINT complaining? I like 'em better indented over.
NAB of course! =)
Contributor
There was a problem hiding this comment.
I'm gonna probably suppress it. =)
I don't know why -- it seems reasonable to me to have that indented over when it's a continuation broken out into separate lines. Like the rule seems a bit whack, or is perhaps misconfigured, IMHO.
groberts314
added
priority: medium
War777
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the work on the PBI I found that
ChipPropTypesdoesn't include thelabelpropertyhttps://github.com/saddlebackdev/church-management/pull/9551