Skip to content

Formal verification: Add an invariant for the singleton address#565

Merged
mmv08 merged 2 commits intomainfrom
certora/singleton-address-doesnt-change
May 31, 2023
Merged

Formal verification: Add an invariant for the singleton address#565
mmv08 merged 2 commits intomainfrom
certora/singleton-address-doesnt-change

Conversation

@mmv08
Copy link
Copy Markdown
Contributor

@mmv08 mmv08 commented May 17, 2023

This PR:

  • Adds a rule that verifies that the singleton address storage at the storage slot 0 or eip-1967 storage slot

@mmv08 mmv08 requested review from a team, Uxio0, akshay-ap and rmeissner and removed request for a team May 17, 2023 14:01
@mmv08 mmv08 changed the title Formal varification: Add an invariant for the singleton address Formal verification: Add an invariant for the singleton address May 17, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 17, 2023

Pull Request Test Coverage Report for Build 5133624671

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.4%) to 92.8%

Totals Coverage Status
Change from base Build 5120082968: -1.4%
Covered Lines: 308
Relevant Lines: 330

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@akshay-ap akshay-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but commenting for reminder: Filter getStorageAt(...) function in the rule to avoid error before merge.

@mmv08 mmv08 force-pushed the certora/singleton-address-doesnt-change branch from e451e09 to 61af266 Compare May 31, 2023 13:39
@mmv08 mmv08 force-pushed the certora/singleton-address-doesnt-change branch from 61af266 to 25014af Compare May 31, 2023 13:43
@mmv08 mmv08 merged commit f37e0ed into main May 31, 2023
@mmv08 mmv08 deleted the certora/singleton-address-doesnt-change branch May 31, 2023 14:23
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants