Skip to content

Formal verification: Verify functions that may change the fallback handler address#566

Merged
mmv08 merged 2 commits intomainfrom
certora/handler
May 31, 2023
Merged

Formal verification: Verify functions that may change the fallback handler address#566
mmv08 merged 2 commits intomainfrom
certora/handler

Conversation

@mmv08
Copy link
Copy Markdown
Contributor

@mmv08 mmv08 commented May 17, 2023

This PR:

  • Adds a rule checking methods that can change the fallback handler address

@mmv08 mmv08 requested review from a team, Uxio0, akshay-ap and rmeissner and removed request for a team May 17, 2023 14:53
@mmv08 mmv08 force-pushed the certora/handler branch from c7a18b8 to e52e98f Compare May 17, 2023 14:53
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 17, 2023

Pull Request Test Coverage Report for Build 5133815773

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.8%

Totals Coverage Status
Change from base Build 5133650407: 0.0%
Covered Lines: 308
Relevant Lines: 330

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@akshay-ap akshay-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but commenting for reminder: Filter getStorageAt(...) function in the rule to avoid error before merge.

@mmv08 mmv08 force-pushed the certora/handler branch from e52e98f to f8d5c47 Compare May 31, 2023 13:45
@mmv08 mmv08 force-pushed the certora/handler branch from 6ccc991 to a68de7e Compare May 31, 2023 14:02
@mmv08 mmv08 merged commit 1b25deb into main May 31, 2023
@mmv08 mmv08 deleted the certora/handler branch May 31, 2023 14:10
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants