Skip to content

Formal verification: Optimistic DELEGATECALL, update nonce monotonicity rule#574

Merged
mmv08 merged 2 commits intomainfrom
certora/update-nonce-monotonicity-rule
May 31, 2023
Merged

Formal verification: Optimistic DELEGATECALL, update nonce monotonicity rule#574
mmv08 merged 2 commits intomainfrom
certora/update-nonce-monotonicity-rule

Conversation

@mmv08
Copy link
Copy Markdown
Contributor

@mmv08 mmv08 commented May 25, 2023

This PR:

  • Adds an optimistic assumption about the DELEGATECALL operation in the Executor contract
  • Update the nonce monotonicity rule to only allow it for the execTransaction method

@mmv08 mmv08 requested review from a team, Uxio0, akshay-ap and rmeissner and removed request for a team May 25, 2023 14:28
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 25, 2023

Pull Request Test Coverage Report for Build 5090552791

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 98.536%

Totals Coverage Status
Change from base Build 4991446336: 1.5%
Covered Lines: 315
Relevant Lines: 316

💛 - Coveralls

@mmv08 mmv08 force-pushed the certora/update-nonce-monotonicity-rule branch from 3d8a4ad to 346a2fc Compare May 26, 2023 12:01
@mmv08 mmv08 merged commit 80ced58 into main May 31, 2023
@mmv08 mmv08 deleted the certora/update-nonce-monotonicity-rule branch May 31, 2023 14:56
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants