Skip to content

Formal verification: No message can be signed through the core contract#583

Merged
mmv08 merged 5 commits intomainfrom
certora/signed-messages
Jun 16, 2023
Merged

Formal verification: No message can be signed through the core contract#583
mmv08 merged 5 commits intomainfrom
certora/signed-messages

Conversation

@mmv08
Copy link
Copy Markdown
Contributor

@mmv08 mmv08 commented Jun 2, 2023

This PR:

  • Adds a rule that checks that no message can be signed through the core contract

@mmv08 mmv08 requested review from a team, Uxio0, akshay-ap and rmeissner and removed request for a team June 2, 2023 13:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 2, 2023

Pull Request Test Coverage Report for Build 5156275448

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 94.2%

Totals Coverage Status
Change from base Build 5134646122: 1.4%
Covered Lines: 315
Relevant Lines: 330

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 2, 2023

Pull Request Test Coverage Report for Build 5291970305

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall First build on certora/signed-messages at 94.2%

Totals Coverage Status
Change from base Build 5291950380: 94.2%
Covered Lines: 315
Relevant Lines: 330

💛 - Coveralls

@mmv08 mmv08 force-pushed the certora/signed-messages branch from 0e93908 to 0721728 Compare June 2, 2023 18:06
@mmv08 mmv08 force-pushed the certora/signed-messages branch from 0721728 to ec0173d Compare June 2, 2023 19:22
Copy link
Copy Markdown
Contributor

@akshay-ap akshay-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmv08 mmv08 merged commit bf943f8 into main Jun 16, 2023
@mmv08 mmv08 deleted the certora/signed-messages branch June 16, 2023 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants