Skip to content

Fix: Certora CI action#591

Merged
mmv08 merged 1 commit intomainfrom
fix/certora-ci
Jun 16, 2023
Merged

Fix: Certora CI action#591
mmv08 merged 1 commit intomainfrom
fix/certora-ci

Conversation

@mmv08
Copy link
Copy Markdown
Contributor

@mmv08 mmv08 commented Jun 15, 2023

The certora CI action broke here: #590 - Failed run

It broke because the version of the certora-cli-beta wasn't pinned, and it installed a new version with breaking changes for the keyword to pass settings to the prover (settings changed to prover_args). This PR:

  • Adjust the keyword
  • Pin version on the excellent version number 4.2.0 (the latest available at the moment)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 15, 2023

Pull Request Test Coverage Report for Build 5282493914

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.8%

Totals Coverage Status
Change from base Build 5282368557: 0.0%
Covered Lines: 308
Relevant Lines: 330

💛 - Coveralls

@mmv08 mmv08 changed the title Fix certora CI action Fix: Certora CI action Jun 15, 2023
@mmv08 mmv08 force-pushed the fix/certora-ci branch 4 times, most recently from fc22a9f to dd43148 Compare June 15, 2023 18:26
@mmv08 mmv08 marked this pull request as ready for review June 15, 2023 19:01
@mmv08 mmv08 requested review from a team, Uxio0, akshay-ap and rmeissner and removed request for a team June 16, 2023 12:28
Copy link
Copy Markdown
Contributor

@akshay-ap akshay-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmv08 mmv08 merged commit eec5ebc into main Jun 16, 2023
@mmv08 mmv08 deleted the fix/certora-ci branch June 16, 2023 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants