Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Pull Request Test Coverage Report for Build 7475596867
💛 - Coveralls |
MissLov3ly
approved these changes
Dec 5, 2023
mmv08
reviewed
Jan 8, 2024
mmv08
reviewed
Jan 8, 2024
nlordell
reviewed
Jan 9, 2024
nlordell
reviewed
Jan 9, 2024
nlordell
reviewed
Jan 9, 2024
nlordell
reviewed
Jan 9, 2024
nlordell
reviewed
Jan 9, 2024
nlordell
reviewed
Jan 10, 2024
nlordell
reviewed
Jan 10, 2024
nlordell
reviewed
Jan 10, 2024
nlordell
approved these changes
Jan 10, 2024
Collaborator
nlordell
left a comment
There was a problem hiding this comment.
LGTM - if it isn't too much hassle, I would propose to move the returndatasize changes to a separate PR so that change doesn't get mixed up in this one.
Contributor
Author
|
Will make a new issue & PR once this is merged for the Thank you all for reviewing this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following things:
Updates the solc used to 0.8.19 (Need confirmation if this should be done @nlordell / @mmv08 ) for both the project as well as FV using Certora.viaIRandoptimizationenabled (To check, use.envfile with solidity version and settings with the appropriate values)memory-safeeither through tags explicitly or by using proper free memory allocation.Closes #544