Rename repository to safe-smart-account#733
Merged
Conversation
Pull Request Test Coverage Report for Build 7584813704
💛 - Coveralls |
nlordell
reviewed
Jan 17, 2024
mmv08
approved these changes
Jan 18, 2024
nlordell
approved these changes
Jan 19, 2024
remedcu
reviewed
Jan 19, 2024
Contributor
remedcu
left a comment
remedcu
left a comment
There was a problem hiding this comment.
Should these be changed as well from Safe Contracts to Safe Smart Account?
https://github.com/safe-global/safe-contracts/blob/feature-719-rename-repository/contracts/common/StorageAccessible.sol#L7
https://github.com/safe-global/safe-contracts/blob/feature-719-rename-repository/contracts/handler/CompatibilityFallbackHandler.sol#L10
https://github.com/safe-global/safe-contracts/blob/feature-719-rename-repository/contracts/libraries/Enum.sol#L5
https://github.com/safe-global/safe-contracts/blob/feature-719-rename-repository/contracts/libraries/SafeStorage.sol#L5
remedcu
reviewed
Jan 19, 2024
remedcu
reviewed
Jan 19, 2024
remedcu
approved these changes
Jan 19, 2024
Contributor
remedcu
left a comment
remedcu
left a comment
There was a problem hiding this comment.
2 small ones, but rest LGTM 👍🏾
Co-authored-by: Shebin John <admin@remedcu.com>
Co-authored-by: Shebin John <admin@remedcu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #719
Changes in PR:
safe-contractswithsafe-smart-account