Skip to content

Commit 0146786

Browse files
NivedhaSenthilzabil
authored andcommitted
getgauge#1604 dont close page on windows headful mode (getgauge#1680)
* getgauge#1604 dont close page on windows headful mode https://bugs.chromium.org/p/chromium/issues/detail?id=1147809 Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com> * use process.platform to get os details Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com> Co-Authored-By: Zabil Cheriya Maliackal <zabil@users.noreply.github.com> Co-authored-by: Zabil Cheriya Maliackal <zabil@users.noreply.github.com> Signed-off-by: saikrishna321 <saikrishna321@yahoo.com>
1 parent c65aac7 commit 0146786

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

lib/taiko.js

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -306,18 +306,20 @@ const _closeBrowser = async () => {
306306
// remove listeners other than JS dialog for beforeUnload on client first to stop executing them when closing
307307
await _client.removeAllListeners();
308308
pageHandler.addJavascriptDialogOpeningListener();
309-
if (!defaultConfig.firefox) {
309+
//TODO: Remove check once fixed https://bugs.chromium.org/p/chromium/issues/detail?id=1147809
310+
if (!defaultConfig.firefox && !(process.platform == 'win32' && defaultConfig.headful)) {
310311
await page.close();
311-
}
312-
await new Promise((resolve) => {
313-
timeout = setTimeout(() => {
314-
resolve();
315-
}, defaultConfig.retryTimeout);
316-
Promise.all(promisesToBeResolvedBeforeCloseBrowser).then(() => {
317-
clearTimeout(timeout);
318-
resolve();
312+
313+
await new Promise((resolve) => {
314+
timeout = setTimeout(() => {
315+
resolve();
316+
}, defaultConfig.retryTimeout);
317+
Promise.all(promisesToBeResolvedBeforeCloseBrowser).then(() => {
318+
clearTimeout(timeout);
319+
resolve();
320+
});
319321
});
320-
});
322+
}
321323
clientProxy = null;
322324
}
323325
connectedToRemoteBrowser ? await _client.Browser.close() : await closeBrowser();

0 commit comments

Comments
 (0)