#1604 dont close page on windows headful mode#1680
Merged
Conversation
https://bugs.chromium.org/p/chromium/issues/detail?id=1147809 Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
zabil
reviewed
Nov 12, 2020
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com> Co-Authored-By: Zabil Cheriya Maliackal <zabil@users.noreply.github.com>
NivedhaSenthil
force-pushed
the
fix_page_close
branch
from
d8fb7fd to
1a6b88f
Compare
saikrishna321
pushed a commit
to saikrishna321/taiko
that referenced
this pull request
Jan 15, 2021
* getgauge#1604 dont close page on windows headful mode https://bugs.chromium.org/p/chromium/issues/detail?id=1147809 Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com> * use process.platform to get os details Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com> Co-Authored-By: Zabil Cheriya Maliackal <zabil@users.noreply.github.com> Co-authored-by: Zabil Cheriya Maliackal <zabil@users.noreply.github.com> Signed-off-by: saikrishna321 <saikrishna321@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.chromium.org/p/chromium/issues/detail?id=1147809
Signed-off-by: NivedhaSenthil nivedhasenthil@gmail.com