Skip to content

Implement fonts#2

Merged
saikumarbt merged 4 commits into
mainfrom
implement-fonts
Jun 22, 2026
Merged

Implement fonts#2
saikumarbt merged 4 commits into
mainfrom
implement-fonts

Conversation

@saikumarbt

Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@saikumarbt, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 37 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 26337a01-b4b8-425a-ad8d-e343d391e957

📥 Commits

Reviewing files that changed from the base of the PR and between 940cf59 and 1d29dad.

📒 Files selected for processing (2)
  • app/_layout.tsx
  • package.json

Walkthrough

Adds PlusJakartaSans font bundling via an expo-font plugin in app.json. RootLayout now loads these fonts using useFonts, hides the splash screen via useEffect, and blocks rendering until fonts are ready. The home tab screen is simplified to a "Home" header with three navigation links. A pre-commit dependency is also added to package.json.

Changes

Font Setup and Home Tab Update

Layer / File(s) Summary
expo-font plugin and asset registration
app.json
Adds an expo-font plugin entry listing six PlusJakartaSans .ttf files so they are bundled with the app.
RootLayout font loading and splash screen gate
app/_layout.tsx
Imports useFonts, SplashScreen, and useEffect; expands RootLayout to load fonts, hide the splash screen once ready, and return null until fontsLoaded is true (contains two consecutive identical if (!fontsLoaded) return null; guards).
Home tab UI simplification
app/(tabs)/index.tsx
Replaces the "Welcome to Nativewind!" text and subscription navigation links with a "Home" header and three styled links to onboarding, sign-in, and sign-up.
pre-commit dependency
package.json
Adds "pre-commit": "^2.0.0" to the dependencies section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐇 Hop, hop, the fonts are here,
PlusJakartaSans landing clear!
The splash hides once they're all in place,
A "Home" screen now takes center stage.
Pre-commit joins the warren too —
A tidy burrow, fresh and new! 🌿

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the purpose of font implementation and any relevant context.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Implement fonts' accurately describes the main change: adding font support (expo-font plugin and custom font loading) to the app.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch implement-fonts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/_layout.tsx`:
- Around line 25-27: The fontsLoaded guard check in app/_layout.tsx is
duplicated, creating unreachable code. Locate the second identical if
(!fontsLoaded) check that returns null and remove it entirely, keeping only the
first occurrence of this guard check to avoid redundant conditions.
- Around line 7-23: Add SplashScreen.preventAutoHideAsync() at the module level
before the component definition to prevent auto-hiding the splash screen while
fonts are loading. Modify the useFonts hook call to capture both fontsLoaded and
error values, then add error handling in the useEffect to call
SplashScreen.hideAsync() and log the error if font loading fails, ensuring the
app does not stall on font-loading failures. Finally, remove the duplicate guard
condition at the end of the component that checks if fontsLoaded is false and
returns null, as this is redundant given the error handling already implemented.

In `@package.json`:
- Line 32: Move the pre-commit package from the dependencies section to the
devDependencies section in package.json. Since pre-commit is a development-only
tool for managing git hooks and not required at runtime, it should be classified
with other dev-only tools like typescript, eslint, and tailwindcss to keep the
production dependency footprint minimal.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: acc37541-4513-4fb2-a7e7-2b57da976d66

📥 Commits

Reviewing files that changed from the base of the PR and between b182303 and 940cf59.

⛔ Files ignored due to path filters (2)
  • assets/images/recurrly_banner.png is excluded by !**/*.png
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (5)
  • README.md
  • app.json
  • app/(tabs)/index.tsx
  • app/_layout.tsx
  • package.json

Comment thread app/_layout.tsx Outdated
Comment thread app/_layout.tsx
Comment thread package.json Outdated
@saikumarbt
saikumarbt merged commit 9c6c65c into main Jun 22, 2026
1 check passed
@coderabbitai coderabbitai Bot mentioned this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant