Skip to content

feat!: use current inquirer - #479

Merged
mdonnalley merged 17 commits into
mainfrom
sm/esm
Jan 5, 2024
Merged

feat!: use current inquirer#479
mdonnalley merged 17 commits into
mainfrom
sm/esm

Conversation

@mshanemc

@mshanemc mshanemc commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: ESM-only

BREAKING CHANGE: removes cross-cloud hooks (deployer, deauthorizer, etc)

BREAKING CHANGE: removes Prompter module

BREAKING CHANGE: remove option to barrel-import from Ux

@W-14674359@


The following PRs use the pre-release package as "proof of correctness" and should be updated once this merges. They can be checked out and built to do manual QA. They also explore what changes this PR will cause.

BREAKING CHANGE: ESM-only

BREAKING CHANGE: removes cross-cloud hooks (deployer, deauthorizer, etc)

BREAKING CHANGE: removes Prompter module

BREAKING CHANGE: remove option to barrel-import from Ux

@mdonnalley mdonnalley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

Looks like you have some merge conflicts though. Also, I'm assuming that the failing nuts are expected?

Comment thread README.md Outdated
@mdonnalley

Copy link
Copy Markdown
Contributor

QA

Generated new sf plugin using sf dev generate plugin, linked this branch of sf-plugins-core to it.

🟢 this.confirm prompts user for Y/n answer
🟢 this.confirm defaults to defaultAnswer after 10 second timeout
this.confirm hangs until timeout despite being answered

🟢 this.secretPrompt prompts user and input is hidden
this.secretPrompt hangs until timeout despite being answered

@mdonnalley

Copy link
Copy Markdown
Contributor

QA
Generated new sf plugin using sf dev generate plugin, linked this branch of sf-plugins-core to it.

🟢 this.confirm prompts user for Y/n answer
🟢 this.confirm defaults to defaultAnswer after 10 second timeout
🟢 this.confirm cancels timeout if answer is given

🟢 this.secretPrompt prompts user and input is hidden
🟢 this.secretPrompt cancels timeout if answer is given

@mshanemc

mshanemc commented Jan 4, 2024

Copy link
Copy Markdown
Contributor Author

Changes look good to me 👍

Looks like you have some merge conflicts though. Also, I'm assuming that the failing nuts are expected?

PDR needs salesforcecli/plugin-deploy-retrieve#866 to even compile without the Deployer hook stuff.

The other 2 (org and signups) are expected results of the breaking changes in here.

Comment thread MIGRATING_V5-V6.md Outdated
Comment thread MIGRATING_V5-V6.md Outdated
Comment thread MIGRATING_V5-V6.md Outdated
Comment thread MIGRATING_V5-V6.md Outdated
@mdonnalley
mdonnalley marked this pull request as ready for review January 5, 2024 21:25
@mdonnalley
mdonnalley requested a review from a team as a code owner January 5, 2024 21:25
@mdonnalley
mdonnalley merged commit 77e33ab into main Jan 5, 2024
@mdonnalley
mdonnalley deleted the sm/esm branch January 5, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants