ci(podman): add state tests in simple container#273
Open
andrii-suse wants to merge 1 commit intosaltstack-formulas:masterfrom
Open
ci(podman): add state tests in simple container#273andrii-suse wants to merge 1 commit intosaltstack-formulas:masterfrom
andrii-suse wants to merge 1 commit intosaltstack-formulas:masterfrom
Conversation
092ed6d to
aea6ecf
Compare
baby-gnu
requested changes
Apr 26, 2023
Contributor
baby-gnu
left a comment
There was a problem hiding this comment.
I think that instead of using a lib as a shebang, you should source the file.
Author
Edit: Ah I don't need to execute those commands that are in the .sh files. I need to setup test environment and pass those commands into that environment. So |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
#267
Describe the changes you're proposing
Currently CI uses kitchen in gitlab runners, which is good, but heavy solution with complex dependencies and non-trivial setup. It is closer to system level testing.
This PR proposes CI on unit-test level, with is convenient way to quickly verify correctness of formula changes or reproduce bugs, etc.
Additional features:
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Linked github workflow should have the logs.
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context