Conversation
…in visitEachChild
Signed-off-by: github-actions <github-actions@github.com>
✅ Deploy Preview for effortless-malabi-1c3e77 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: github-actions <github-actions@github.com>
src/event-bridge/event-bus.ts
Outdated
| const objectProps = arg.properties.map((prop) => { | ||
| if ( | ||
| !isPropAssignExpr(prop) || | ||
| !(isIdentifier(prop.name) || isStringLiteralExpr(prop.name)) |
There was a problem hiding this comment.
nit: are the parens necessary?
There was a problem hiding this comment.
Would it be easier to check for what's allowed instead of the !? I am confused.
There was a problem hiding this comment.
what about numeric properties?
There was a problem hiding this comment.
Looks like that is our miss
export type PropertyName = Identifier | StringLiteral | NumericLiteral | ComputedPropertyName | PrivateIdentifier
test/api.test.ts
Outdated
| return "success"; | ||
| } | ||
| ) | ||
| ).toThrow("object literal"); |
There was a problem hiding this comment.
Is this the whole message it throws?
There was a problem hiding this comment.
No, toThrow does a contains.
…heck of for-in initializer
|
Rebased onto #347 to reflect the change before it gets pushed. |
sam-goodwin
left a comment
sam-goodwin
left a comment
There was a problem hiding this comment.
Looks like there are changes brought across from my ast change? Merge problems?
2 participants
Depends on #347