feat: use standard errors library join instead of hashicorp multierror#8
Merged
samber merged 1 commit intosamber:mainfrom Jun 4, 2024
Merged
feat: use standard errors library join instead of hashicorp multierror#8samber merged 1 commit intosamber:mainfrom
samber merged 1 commit intosamber:mainfrom
Conversation
Owner
|
I definitely agree 😅 Thanks for the fix. |
renovate bot
referenced
this pull request
in jippi/dottie
Jun 5, 2024
….mod (#52) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/slog-multi](https://togithub.com/samber/slog-multi) | `v1.0.2` -> `v1.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>samber/slog-multi (github.com/samber/slog-multi)</summary> ### [`v1.1.0`](https://togithub.com/samber/slog-multi/releases/tag/v1.1.0) [Compare Source](https://togithub.com/samber/slog-multi/compare/v1.0.3...v1.1.0) #### What's Changed - feat: use standard errors library join instead of hashicorp multierror by [@​mat007](https://togithub.com/mat007) in [https://github.com/samber/slog-multi/pull/8](https://togithub.com/samber/slog-multi/pull/8) - fix: clone attributes for each handler by [@​mat007](https://togithub.com/mat007) in [https://github.com/samber/slog-multi/pull/9](https://togithub.com/samber/slog-multi/pull/9) #### New Contributors - [@​mat007](https://togithub.com/mat007) made their first contribution in [https://github.com/samber/slog-multi/pull/8](https://togithub.com/samber/slog-multi/pull/8) **Full Changelog**: samber/slog-multi@v1.0.3...v1.1.0 ### [`v1.0.3`](https://togithub.com/samber/slog-multi/releases/tag/v1.0.3) [Compare Source](https://togithub.com/samber/slog-multi/compare/v1.0.2...v1.0.3) #### What's Changed - feat: multierror support by [@​savely-krasovsky](https://togithub.com/savely-krasovsky) in [https://github.com/samber/slog-multi/pull/7](https://togithub.com/samber/slog-multi/pull/7) #### New Contributors - [@​savely-krasovsky](https://togithub.com/savely-krasovsky) made their first contribution in [https://github.com/samber/slog-multi/pull/7](https://togithub.com/samber/slog-multi/pull/7) **Full Changelog**: samber/slog-multi@v1.0.2...v1.0.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* */8 * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jippi/dottie). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7
It’s arguably best to use the standard library when possible.
Also the licensing of https://github.com/hashicorp/go-multierror is a bit annoying, e.g. see «3.2. Distribution of Executable Form».
Thanks!