Skip to content

fix: clone attributes for each handler#9

Merged
samber merged 1 commit intosamber:mainfrom
mat007:clone-attr
Jun 4, 2024
Merged

fix: clone attributes for each handler#9
samber merged 1 commit intosamber:mainfrom
mat007:clone-attr

Conversation

@mat007
Copy link
Copy Markdown
Contributor

@mat007 mat007 commented Jun 1, 2024

Hey!

The docs say this for slog.Handler.WithAttrs:

The Handler owns the slice: it may retain, modify or discard it.

Therefore, it seems best to clone it for each handler in a multi-handler.

@samber samber merged commit 09a829e into samber:main Jun 4, 2024
renovate bot referenced this pull request in jippi/dottie Jun 5, 2024
….mod (#52)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/samber/slog-multi](https://togithub.com/samber/slog-multi)
| `v1.0.2` -> `v1.1.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2fslog-multi/v1.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2fslog-multi/v1.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2fslog-multi/v1.0.2/v1.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2fslog-multi/v1.0.2/v1.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>samber/slog-multi (github.com/samber/slog-multi)</summary>

###
[`v1.1.0`](https://togithub.com/samber/slog-multi/releases/tag/v1.1.0)

[Compare
Source](https://togithub.com/samber/slog-multi/compare/v1.0.3...v1.1.0)

#### What's Changed

- feat: use standard errors library join instead of hashicorp multierror
by [@&#8203;mat007](https://togithub.com/mat007) in
[https://github.com/samber/slog-multi/pull/8](https://togithub.com/samber/slog-multi/pull/8)
- fix: clone attributes for each handler by
[@&#8203;mat007](https://togithub.com/mat007) in
[https://github.com/samber/slog-multi/pull/9](https://togithub.com/samber/slog-multi/pull/9)

#### New Contributors

- [@&#8203;mat007](https://togithub.com/mat007) made their first
contribution in
[https://github.com/samber/slog-multi/pull/8](https://togithub.com/samber/slog-multi/pull/8)

**Full Changelog**:
samber/slog-multi@v1.0.3...v1.1.0

###
[`v1.0.3`](https://togithub.com/samber/slog-multi/releases/tag/v1.0.3)

[Compare
Source](https://togithub.com/samber/slog-multi/compare/v1.0.2...v1.0.3)

#### What's Changed

- feat: multierror support by
[@&#8203;savely-krasovsky](https://togithub.com/savely-krasovsky) in
[https://github.com/samber/slog-multi/pull/7](https://togithub.com/samber/slog-multi/pull/7)

#### New Contributors

- [@&#8203;savely-krasovsky](https://togithub.com/savely-krasovsky) made
their first contribution in
[https://github.com/samber/slog-multi/pull/7](https://togithub.com/samber/slog-multi/pull/7)

**Full Changelog**:
samber/slog-multi@v1.0.2...v1.0.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* */8 * * *" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/jippi/dottie).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODguMSIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants