Conversation
There is a concrete risk of a translation mismatch because of the continuos Plus UI changes. Since the latest Turkish update, more than 20 versions were released, so the Plus support for Turkish should be turned off. If you want to update and restore Plus translation, please open a new issue.
4b9f3a9 to
972a455
Compare
Collaborator
|
The disabling in Languages.iss is OK. I am not sure about the parsing of SandMan.pri. Those backslashes at the end of the lines are continuation characters. The backslash and newline sequence will be stripped and the next line will be joined with the previous line. So this effect may happen when parsed:
I would suggest to move the commented If the parser strips the comment lines, then strips the line continuations and joins the lines, then it might be OK. That I am unsure if it will do that without testing it. |
mpheath
approved these changes
Sep 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a concrete risk of a translation mismatch because of the continuos Plus UI changes. Since the latest Turkish update, more than 20 versions were released, so the Plus support for Turkish should be turned off.
If you want to update and restore the translation for Sandboxie Plus, please open a new issue.