Skip to content

Cleanup critical sections#1686

Merged
DavidXanatos merged 1 commit intosandboxie-plus:masterfrom
chunyou128:master
Mar 20, 2022
Merged

Cleanup critical sections#1686
DavidXanatos merged 1 commit intosandboxie-plus:masterfrom
chunyou128:master

Conversation

@chunyou128
Copy link
Contributor

@chunyou128 chunyou128 commented Mar 13, 2022

Originally posted by the author in #1677
I can't find a proper place to clean critical section for sbiedll.dll

@chunyou128 chunyou128 marked this pull request as draft March 13, 2022 09:55
@isaak654 isaak654 marked this pull request as ready for review March 13, 2022 16:34
@isaak654 isaak654 changed the title cleanup critical section(SbieDll.dll is not included). Cleanup critical sections Mar 13, 2022
@isaak654 isaak654 requested a review from DavidXanatos March 13, 2022 19:55
@DavidXanatos
Copy link
Member

thanks, I'll check it out on the weekend and apply if everythign check out fine

Copy link
Member

@DavidXanatos DavidXanatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine, I'll comment out the change in dllmain.c for now though

@DavidXanatos DavidXanatos merged commit fb24541 into sandboxie-plus:master Mar 20, 2022
@isaak654
Copy link
Collaborator

@chunyou128
Thank you for your valuable contribution.
If you'd like to join the Sandboxie-Plus Slack channel, you can send a request to the email listed on David's Github profile.

@DavidXanatos
Copy link
Member

@chunyou128 and even if you may not want to join slack drop me an email to get your perpetual sandboxie certificate ;)

@chunyou128
Copy link
Contributor Author

chunyou128 commented Apr 4, 2022

@chunyou128 Thank you for your valuable contribution. If you'd like to join the Sandboxie-Plus Slack channel, you can send a request to the email listed on David's Github profile.

I have submitted the application with QQ mailbox(redacted) and asked for approval. thanks.

@chunyou128
Copy link
Contributor Author

@chunyou128 and even if you may not want to join slack drop me an email to get your perpetual sandboxie certificate ;)

I am very honored if I can get the perpetual sandboxie certificate.Thank you very much.

@chunyou128
Copy link
Contributor Author

chunyou128 commented Apr 4, 2022

my email:redacted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants