Korean.isl - Update encoding#2173
Merged
DavidXanatos merged 4 commits intosandboxie-plus:masterfrom Aug 22, 2022
VenusGirl:master
Merged
Korean.isl - Update encoding#2173DavidXanatos merged 4 commits intosandboxie-plus:masterfrom VenusGirl:master
DavidXanatos merged 4 commits intosandboxie-plus:masterfrom
VenusGirl:master
Conversation
Collaborator
|
Fair enough, but the line ending should be the same of the other .isl files (LF). |
Collaborator
|
I think this should be properly tested by @DavidXanatos before merging, otherwise we risk running in circles. |
Member
|
if this looks right: then the PR can be merged |
Contributor
Author
|
Now I can see the Korean language correctly. |
isaak654
added a commit
that referenced
this pull request
Aug 22, 2022
As the Chinese .isl files: #2173
Member
|
I just saw the current 1.3.2 installer is missing the fix, a new one will be provided soon |
Contributor
Author
|
Yes! When installing sandboxie-plus, it is not displayed properly due to a Korean.isl encoding problem. If you ignore it and continue installing it, sandboxie-plus will run normally, but shortcuts will not be created properly.
|
Member
|
fixed installer uploaded please test |
Contributor
Author
|
All are now well displayed when you install it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the encoding because there was a problem with Korean not being displayed properly when installation