Fixed the problem that m_pCleanUpButton UI is displayed empty when NoIcons=1.

[okrc]

Fixed the problem that m_pCleanUpButton UI is displayed empty when NoIcons=1.

[isaak654]

I think there should be a vertical separator between "Keep terminated" and "Cleanup".

[okrc]

I think there should be a vertical separator between "Keep terminated" and "Cleanup".

Added.

[isaak654]

This is happening with W7 / W11 x64, and there is no top border in the first two buttons:

EDIT: it is a thing even in older Sandman builds.
Resolved by okrc: #2280

[isaak654]

Of course, my last review still stands (merging or not).

[DavidXanatos]

I have commented out the separator, its intended that the vertical bars are not ever ware, rest of the changes are in and active

[isaak654]

I have commented out the separator, its intended that the vertical bars are not ever ware, rest of the changes are in and active

This might be fine, but the visual inconsistency with Win7 (which is still supported in SBIE at this time) is still there.

[okrc]

@isaak654 I zoomed in several times and found that this problem also exists on Windows 11, which is supposed to be caused by m_pMenuBar.

Sandboxie/SandboxiePlus/SandMan/SandMan.cpp

Lines 175 to 181 in af32bd5

	QWidget* pMenuWidget = new QWidget(this);
	m_pMenuLayout = new QHBoxLayout(pMenuWidget);
	m_pMenuLayout->setContentsMargins(0, 0, 0, 0);
	m_pMenuLayout->addWidget(m_pMenuBar);
	//m_pMenuLayout->addWidget(m_pLabel);
	//m_pMenuLayout->addStretch(10);
	setMenuWidget(pMenuWidget);

Commenting out this code should solve the problem, I'm not sure what the intent of this code is.
I tried to change it to

	QWidget* pMenuWidget = new QWidget(this);
	m_pMenuLayout = new QHBoxLayout(pMenuWidget);
	m_pMenuLayout->setContentsMargins(0, 0, 0, 0);
	//m_pMenuLayout->addWidget(m_pMenuBar);
	m_pMenuLayout->setMenuBar(m_pMenuBar);
	//m_pMenuLayout->addWidget(m_pLabel);
	//m_pMenuLayout->addStretch(10);
	setMenuWidget(pMenuWidget);

It seems to be solved.

[isaak654]

@okrc
I can confirm that your latest modification works well in a separate test build.
If you're planning to create a new pull request with the m_pMenuBar fix, I'm going to merge it straight away.

[okrc]

@isaak654
I created #2280