SP-1985 Accepting None as a possible list item on DBNSFP#13
Merged
kchatzikok merged 1 commit intomasterfrom Dec 15, 2020
Merged
SP-1985 Accepting None as a possible list item on DBNSFP#13kchatzikok merged 1 commit intomasterfrom
kchatzikok merged 1 commit intomasterfrom
Conversation
…values change on the api
kchatzikok
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes in the API response altered the dbnsfp values returned, that can include None as a possible list item.
The client therefore being strict on the item types accepted, was raising errors.
A fix has been included that allows None to be a valid list item on dbnsfp properties.
The python test suite of the client reports no errors