Skip to content

Included acmg verdict in annotated vcf#14

Merged
kchatzikok merged 9 commits intomasterfrom
annotate_acmg_vcf_verdict
May 27, 2022
Merged

Included acmg verdict in annotated vcf#14
kchatzikok merged 9 commits intomasterfrom
annotate_acmg_vcf_verdict

Conversation

@ckopanos
Copy link
Copy Markdown
Member

@ckopanos ckopanos commented Apr 16, 2021

Code changes required to

  1. Support for python versions > 3.6
  2. Include the acmg verdict by default when annotating a vcf
  3. Fix issues with the vcf annotator not correctly storing the alternate sequence
  4. Fix issues when the api responds with an error code on batch requests
  5. Formatting changes

…ttp request totally fails, fixed files formatting
@ckopanos ckopanos force-pushed the annotate_acmg_vcf_verdict branch from d7f5a3d to a4f874d Compare May 16, 2022 19:14
@argyris-gardelakos
Copy link
Copy Markdown
Contributor

The only thing that is failing for me on staging server is when I am running the varsome_api_annotate_vcf.py i get the following error (python 3.8) @ckopanos do you think it is something on my end?

Traceback (most recent call last):
  File "/usr/local/bin/varsome_api_annotate_vcf.py", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/home/gardelakosa/repos/varsome-api-client-python/scripts/varsome_api_annotate_vcf.py", line 19, in <module>
    from varsome_api.vcf import VCFAnnotator
  File "/home/gardelakosa/repos/varsome-api-client-python/varsome_api/vcf.py", line 20, in <module>
    from vcf.parser import _Info, _encode_type
ImportError: cannot import name '_encode_type' from 'vcf.parser' (/usr/local/lib/python3.8/dist-packages/vcf/parser.py)

Copy link
Copy Markdown
Contributor

@argyris-gardelakos argyris-gardelakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Tested on prod and staging as I don't have Token in stable-api (pending from Yolanda)

Comment thread README.md
"""
vcf_template.infos['gnomad_exomes_AN'] = _Info('gnomad_exomes_AN', '.', 'Integer',
'GnomAD exomes allele number value', None, None)
vcf_template.infos['gnomad_exomes_AN'] = _Info('gnomad_exomes_AN', 1, 'Integer',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the second parameter change from '.' to 1? If yes ignore my comment. If no, there are other places in the code that this has changed

@kchatzikok kchatzikok self-requested a review May 27, 2022 10:01
@kchatzikok kchatzikok merged commit 46e47c6 into master May 27, 2022
@ckopanos ckopanos deleted the annotate_acmg_vcf_verdict branch May 27, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants