Included acmg verdict in annotated vcf#14
Merged
kchatzikok merged 9 commits intomasterfrom May 27, 2022
Merged
Conversation
…ttp request totally fails, fixed files formatting
d7f5a3d to
a4f874d
Compare
…with the vcf annotator
…me-api-client-python into annotate_acmg_vcf_verdict
Contributor
|
The only thing that is failing for me on staging server is when I am running the varsome_api_annotate_vcf.py i get the following error (python 3.8) @ckopanos do you think it is something on my end? |
argyris-gardelakos
approved these changes
May 24, 2022
Contributor
argyris-gardelakos
left a comment
There was a problem hiding this comment.
Seems good to me. Tested on prod and staging as I don't have Token in stable-api (pending from Yolanda)
kchatzikok
reviewed
May 27, 2022
| """ | ||
| vcf_template.infos['gnomad_exomes_AN'] = _Info('gnomad_exomes_AN', '.', 'Integer', | ||
| 'GnomAD exomes allele number value', None, None) | ||
| vcf_template.infos['gnomad_exomes_AN'] = _Info('gnomad_exomes_AN', 1, 'Integer', |
Contributor
There was a problem hiding this comment.
Should the second parameter change from '.' to 1? If yes ignore my comment. If no, there are other places in the code that this has changed
kchatzikok
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes required to