SP-3283 Improve the Python API client to include more cases#20
Merged
kchatzikok merged 2 commits intomasterfrom Sep 2, 2022
Merged
Conversation
sfendourakis
requested review from
DathanasiadisSaphetor,
ckopanos,
gpanouts and
kchatzikok
sfendourakis
commented
Jul 6, 2022
Author
sfendourakis
left a comment
sfendourakis
left a comment
There was a problem hiding this comment.
@ckopanos
I would appreciate suggestions on whether I need to add similar examples for vcf annotations. It's not clear to me the use case of such examples for vcf annotation.
argyris-gardelakos
approved these changes
Jul 7, 2022
sfendourakis
commented
Jul 8, 2022
Author
sfendourakis
left a comment
sfendourakis
left a comment
There was a problem hiding this comment.
After a talk with @kchatzikok we decided to add vcf annotation examples.
@argyris-gardelakos please have a look at these too.
sfendourakis
force-pushed
the
SP-3283-improve-the-python-api-client-to-include-more-cases
branch
from
5409df1 to
9b882b1
Compare
argyris-gardelakos
approved these changes
Aug 9, 2022
Contributor
argyris-gardelakos
left a comment
argyris-gardelakos
left a comment
There was a problem hiding this comment.
looks good to me.
Run both new examples without any issues:
kchatzikok
approved these changes
Aug 11, 2022
added 2 commits
September 2, 2022 12:44
…les. Also updated outdated links
sfendourakis
force-pushed
the
SP-3283-improve-the-python-api-client-to-include-more-cases
branch
from
908275b to
be596e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added cancer/tissue type and phenotype/disease examples. Also updated outdated links.