Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"npm": "3.10.3"
},
"dependencies": {
"axios": "^0.12.0",
"axios": "^1.13.5",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified version ^1.13.5 for axios is invalid and does not exist in the npm registry. This will cause npm install to fail. Please correct this to a valid version of axios that resolves the security vulnerability.

"babel-eslint": "^6.1.0",
"babel-loader": "^6.2.4",
"babel-plugin-transform-object-rest-spread": "^6.8.0",
Expand Down Expand Up @@ -40,15 +40,15 @@
"gulp-concat": "^2.5.2",
"gulp-eslint": "^0.14.0",
"gulp-istanbul": "^0.9.0",
"gulp-livereload": "^3.7.0",
"gulp-livereload": "^4.0.0",
"gulp-minify-css": "^0.4.6",
"gulp-mocha": "^2.0.0",
"gulp-newer": "^1.2.0",
"gulp-ng-annotate": "^0.5.2",
"gulp-notify": "^2.2.0",
"gulp-plumber": "^0.6.6",
"gulp-rename": "^1.2.0",
"gulp-sass": "^2.0.4",
"gulp-sass": "^5.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading gulp-sass from v2 to v5 is a major breaking change. gulp-sass v5 uses Dart Sass by default and requires a different initialization in your gulpfile.js. The current configuration will cause your build process to fail.

To fix this, you need to:

  1. Add sass as a new dev dependency: npm install -D sass.
  2. Update gulpfile.js to initialize gulp-sass correctly:
// Change this:
var sass = require('gulp-sass');

// To this:
const sass = require('gulp-sass')(require('sass'));

Without these changes, the Gulp tasks that rely on sass will break.

"gulp-sourcemaps": "^1.3.0",
"gulp-uglify": "^1.1.0",
"history": "^3.0.0",
Expand Down