Skip to content

[Snyk] Security upgrade react-scripts from 1.0.11 to 5.0.0 #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabharch wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade react-scripts from 1.0.11 to 5.0.0 #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fixtures/attribute-behavior/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"glamor": "^2.20.40",
"react": "^15.6.1",
"react-dom": "^15.6.1",
"react-scripts": "1.0.11",
"react-scripts": "5.0.0",
Comment on lines 8 to +10
Copy link

@gemini-code-assist gemini-code-assist bot Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The upgrade of react-scripts to version 5.0.0 is a major change that introduces incompatibilities with other dependencies and code in this project.

  1. React Version Incompatibility: react-scripts@5.0.0 requires React version 17 or 18, but this project is using React 15 (^15.6.1). This mismatch will likely cause the build and tests to fail. You should upgrade react and react-dom to a compatible version, for example ^17.0.2.

  2. Other Dependencies: Upgrading React to version 17 may cause issues with other dependencies that are not compatible with it:

    • react-virtualized@^9.9.0: This version is quite old. You might need to upgrade it to a more recent version (e.g., ^9.22.3) for React 17 compatibility.
    • glamor@^2.20.40: This library appears to be unmaintained and might not be compatible with newer versions of React. It may need to be replaced.

  3. Error Overlay Import: App.js imports from react-error-overlay/lib/overlay. This package is deprecated and its functionality is now part of react-dev-utils, which is included in react-scripts@5. This import path will likely be broken and will need to be updated.

Given these cascading dependency and code issues, simply upgrading react-scripts is not enough and will likely break this fixture. A more comprehensive update of dependencies and related code is required.

Suggested change
"react": "^15.6.1",
"react-dom": "^15.6.1",
"react-scripts": "1.0.11",
"react-scripts": "5.0.0",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-scripts": "5.0.0",

"react-virtualized": "^9.9.0"
},
"scripts": {
Expand Down
Loading