forked from facebook/react
-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade react-scripts from 1.1.5 to 5.0.0 #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saurabharch
wants to merge
1
commit into
master
Choose a base branch
from
snyk-fix-32434cb4dae12138f2c67caa42418e80
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading
react-scriptsfrom version 1 to 5 is a significant leap that spans multiple major versions. Each major version ofreact-scriptsintroduced substantial changes to its underlying dependencies like Webpack, Babel, and Jest.Some potential issues to watch out for:
react-scripts@5) has numerous breaking changes compared to Webpack 3 (inreact-scripts@1). This could affect custom build configurations if any exist. Similarly, Jest, Babel, and ESLint have been upgraded significantly.react-scripts@5is tested against stable React versions. There's a risk of incompatibility with the specific experimental features or APIs used here.react-scripts@5requires Node.js 14 or later. Please ensure your development and CI/CD environments meet this requirement.Given the high risk of breaking changes, extensive testing of the build, development server, tests, and overall application functionality is strongly recommended.