Renaming test resources in examples#398
Merged
Merged
Conversation
nulls
reviewed
Jun 7, 2022
nulls
approved these changes
Jun 7, 2022
| @@ -1,5 +1,5 @@ | |||
| [general] | |||
| execCmd = "java -jar ktlint-old --disabled_rules=standard -R diktat-old.jar" | |||
| execCmd = "java -jar ktlint --disabled_rules=standard -R diktat.jar" | |||
Member
There was a problem hiding this comment.
we release diktat in format diktat-*.jar, maybe change it to java -jar ktlint --disabled_rules=standard -R diktat-*.jar?
- removed "old" binaries
orchestr7
force-pushed
the
feature/updating-examples
branch
from
3d9a814 to
7dcb797
Compare
nulls
reviewed
Jun 15, 2022
orchestr7
force-pushed
the
feature/updating-examples
branch
2 times, most recently
from
355b5a7 to
7faf092
Compare
- removed "old" binaries
- removed "old" binaries
orchestr7
force-pushed
the
feature/updating-examples
branch
from
7faf092 to
78d41a0
Compare
…rtool/save-cli into feature/updating-examples � Conflicts: � examples/kotlin-diktat/warn/chapter1/EnumValueSnakeCaseTest.kt � save-core/src/commonNonJsTest/kotlin/com/saveourtool/save/core/test/utils/TestUtilsCommon.kt
- removed "old" binaries
- removed "old" binaries
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- removed "old" binaries
orchestr7
force-pushed
the
feature/updating-examples
branch
from
4944da3 to
cf0212c
Compare
orchestr7
commented
Jun 20, 2022
| // offset that is used to restore indexes in the initial string (as the logic below is applied to substring) | ||
| var offset = delimitedGroup.second + closingDelimiter.length | ||
|
|
||
| return if (delimitedGroup == delimiterNotFound) { |
Member
Author
There was a problem hiding this comment.
unfortunately we had a bug in Regex mechanism
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done: